This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Merged
Conversation
|
@DrianHillman always exciting to see people contribute to Atom! One thing is that the travis build is failing. The failure is due to: Can you fix these linting issues? Once the issues are fixed, I'll test the changes. I'll run it by the team and see if we can get this merged in the near future. |
9852bee to
3878bc4
Compare
Contributor
Author
|
Absolutely, good catch @ungb— I just pushed an update. Thanks for pointing that out, I'm able to see in Travis' build where they flagged that warning. Something I'll look out for going forward! 👍🏽 Always |
|
Looks good, will merge once build passes. Rerunning. before: after: |
|
LGTM! 🎉 Thanks for submitting this PR! Thanks @BinaryMuse with all your help! |
This was referenced Aug 1, 2017
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR implements the recommended solution for issue #772. The text for PR labels in the GitHub pane will now dynamically use the most readable color (black or white) based on the set background color of the label.
Screenshots of the change here:
Before
After
Alternate Designs
Design-wise we can play with adding more text color options to the list of arguments (i.e. off-blacks, greys, and off-whites); but this edit makes the text certainly readable which is why it was chosen.
Benefits
The PR labels on the GitHub pane will now be 100% readable to all users, especially those with dark themed editors! 🎉
Possible Drawbacks
It adds 1 additional package to the project (TinyColor), but it is a very low-risk implementation. This calls on only 1 of the package's methods, so the logic here may be forked if necessary (MIT License).
Applicable Issues
None.
This is my first PR and I must say it is extremely exciting to contribute to Atom! I'm looking forward to contributing in the future as well!